Added not wasm config for get_ancestors #386
Conversation
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
==========================================
- Coverage 78.25% 78.23% -0.02%
==========================================
Files 275 275
Lines 27447 27454 +7
==========================================
Hits 21479 21479
- Misses 5968 5975 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…lectionViewNodeItem
|
| #[cfg(feature = "uniffi")] | ||
| use uniffi; |
There was a problem hiding this comment.
issue: You shouldn't need to use uniffi here, since you use the full path below.
| #[cfg(feature = "uniffi")] | |
| use uniffi; |
| #[cfg_attr(feature = "wasm", derive(Tsify, Serialize, Deserialize))] | ||
| #[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))] |
There was a problem hiding this comment.
We usually combine ´cfg_attr` with the same condition into a single.
| #[cfg_attr(feature = "wasm", derive(Tsify, Serialize, Deserialize))] | |
| #[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))] | |
| #[cfg_attr( | |
| feature = "wasm", | |
| derive(Tsify, Serialize, Deserialize), | |
| tsify(into_wasm_abi, from_wasm_abi) | |
| )] |
| #[cfg_attr(feature = "wasm", tsify(into_wasm_abi, from_wasm_abi))] | ||
| #[cfg_attr(feature = "uniffi", derive(uniffi::Record))] | ||
| pub struct AncestorMap { | ||
| pub ancestors: HashMap<Uuid, String>, |
There was a problem hiding this comment.
question: Should this be Uuid or CollectionId?
🎟️ Tracking
PM-25167
📔 Objective
Adds conditional code for when wasm feature isn't enabled for get_ancestors.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes