Skip to content

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Aug 14, 2025

🎟️ Tracking

PM-25167

📔 Objective

Adds conditional code for when wasm feature isn't enabled for get_ancestors.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor

github-actions bot commented Aug 14, 2025

Logo
Checkmarx One – Scan Summary & Details473916d7-2add-4f20-8d58-0662449d2ccf

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.23%. Comparing base (e30f1ea) to head (b029292).

Files with missing lines Patch % Lines
crates/bitwarden-uniffi/src/vault/collections.rs 0.00% 19 Missing ⚠️
crates/bitwarden-vault/src/collection_client.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
- Coverage   78.25%   78.23%   -0.02%     
==========================================
  Files         275      275              
  Lines       27447    27454       +7     
==========================================
  Hits        21479    21479              
- Misses       5968     5975       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jrmccannon jrmccannon marked this pull request as ready for review September 19, 2025 20:46
@jrmccannon jrmccannon requested review from a team as code owners September 19, 2025 20:46
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants